Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check wK write permission before organization creation #4501

Merged
merged 4 commits into from
Mar 30, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Mar 26, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create an organization when the datastore doesn't has write permission => should not work
  • create an organization when the datastore has write permission => should still work

Issues:


@youri-k youri-k requested a review from fm3 March 26, 2020 13:41
@youri-k youri-k self-assigned this Mar 26, 2020
@youri-k
Copy link
Contributor Author

youri-k commented Mar 26, 2020

I went with checking the write permission beforehand and leaving the folder creation at the end because otherwise the folder creation would be done without authentication.

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking concerning the authentication :) I left a comment about the error messages. With that done this should be good to go!

conf/messages Outdated Show resolved Hide resolved
@youri-k youri-k merged commit ea6b392 into master Mar 30, 2020
@philippotto philippotto deleted the check-new-organization-folder branch June 14, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if organization creation fails (due to no write permission in binaryData), user is stuck
2 participants