Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Overwriting Missing Datasets From Different Datastore #4465

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Allow Overwriting Missing Datasets From Different Datastore #4465

merged 3 commits into from
Mar 23, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 4, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • set up two datastores (e.g. localhost and a standalone), mark one as scratch
  • move a dataset between the two, refresh dataset list
  • dataset should be reported wherever it is
  • if both have the dataset, the non-scratch one should take precedence over scratch
  • if two non-scratch datasets have the dataset, the first one that reported it keeps it

Issues:

@fm3 fm3 added the backend label Mar 4, 2020
@fm3 fm3 self-assigned this Mar 4, 2020
@fm3 fm3 requested a review from youri-k March 4, 2020 15:16
youri-k
youri-k approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 added the automerge label Mar 23, 2020
@bulldozer-boy bulldozer-boy bot merged commit c4d9acb into master Mar 23, 2020
@bulldozer-boy bulldozer-boy bot deleted the replace-unreported-even-from-scratch branch March 23, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
automerge backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to move dataset from live to scratch datastore
2 participants
@fm3 @youri-k