Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable node creation with right mouse when brushing #4433

Merged
merged 13 commits into from
Mar 10, 2020
Merged

Disable node creation with right mouse when brushing #4433

merged 13 commits into from
Mar 10, 2020

Conversation

MichaelBuessemeyer
Copy link
Contributor

This PR disabled node creation with right-click while in brushing mode in hybrid tracings.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a hybrid tracing. Select the brush mode and try to create nodes using right-click.
  • Do keep the button pressed as this does not trigger a click action.

Issues:

@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Feb 4, 2020
@MichaelBuessemeyer MichaelBuessemeyer changed the title disable node creation with right mouse when brushing Disable node creation with right mouse when brushing Feb 4, 2020
@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto I also added #4427. I am not sure which bounding box to disable, the user bb or the task bb 😕

@philippotto
Copy link
Member

@philippotto I also added #4427. I am not sure which bounding box to disable, the user bb or the task bb

I think, both should be disabled :)

@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto Could you please review these changes again?

@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto Could you please re-review this PR?

philippotto
philippotto approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! See my last nitpick, but other than that this should be good to go 👍

frontend/javascripts/oxalis/controller/scene_controller.js Outdated Show resolved Hide resolved
@MichaelBuessemeyer MichaelBuessemeyer merged commit 204a056 into master Mar 10, 2020
@MichaelBuessemeyer MichaelBuessemeyer mentioned this pull request Mar 16, 2020
Closed
@fm3 fm3 deleted the no-node-creation-while-brushing branch March 20, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@MichaelBuessemeyer MichaelBuessemeyer

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right click in hybrid brush-mode also creates node
2 participants
@MichaelBuessemeyer @philippotto