Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task creation can use task id #4404

Merged
merged 11 commits into from
Jan 23, 2020
Merged

Task creation can use task id #4404

merged 11 commits into from
Jan 23, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Jan 10, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • try using a task id as base id for task creation

Issues:

@youri-k youri-k self-assigned this Jan 10, 2020
philippotto
philippotto reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front-end looks good to me :) See my one suggestion, though.

frontend/javascripts/admin/task/task_create_form_view.js Outdated Show resolved Hide resolved
fm3
fm3 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM, I added two small suggestions :)

app/controllers/TaskController.scala Outdated Show resolved Hide resolved
conf/messages Outdated Show resolved Hide resolved
@youri-k youri-k merged commit 6fba47e into master Jan 23, 2020
@fm3 fm3 deleted the task-creation-base-task-id branch January 23, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto left review comments

@fm3 fm3 fm3 approved these changes

Assignees

@youri-k youri-k

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task creation: use Task ID as base
3 participants
@youri-k @fm3 @philippotto