Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved initial data and configs #4368

Merged
merged 8 commits into from
Dec 11, 2019
Merged

Improved initial data and configs #4368

merged 8 commits into from
Dec 11, 2019

Conversation

normanrz
Copy link
Member

  • Renames initial organization to sample
  • Refactors uri specification in config
  • Replaces default operatorData

Steps to test:

  • Clone webknossos on a remote server
  • Set the *.publicUri fields in the docker-compose.yml
  • Start webKnossos and see if it works

Issues:

@normanrz normanrz requested a review from fm3 December 10, 2019 12:21
@normanrz normanrz self-assigned this Dec 10, 2019
fm3
fm3 approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

philippotto
philippotto approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

.prettierignore Outdated
package.json
CHANGELOG.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe *.md in general?

@normanrz normanrz merged commit 8cc05e5 into master Dec 11, 2019
@normanrz normanrz deleted the generic-initial-data branch December 11, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

@fm3 fm3 fm3 approved these changes

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify/fix basic docker setup for single instances
3 participants
@normanrz @fm3 @philippotto