Skip to content

Disable volume shortcuts in read-only mode #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2019
Merged

Disable volume shortcuts in read-only mode #4345

merged 4 commits into from
Dec 2, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 27, 2019 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • open a volume (or hybrid) tracing in read-only and try to cycle through the different tools with w

Issues:

@philippotto philippotto self-assigned this Nov 27, 2019
@philippotto philippotto force-pushed the disable-volume-shortcuts-in-read-only branch from d15f799 to 216fd46 Compare November 27, 2019 16:49
daniel-wer
daniel-wer approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bulldozer-boy bulldozer-boy bot merged commit f370c3e into master Dec 2, 2019
@bulldozer-boy bulldozer-boy bot deleted the disable-volume-shortcuts-in-read-only branch December 2, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brush mode can be activated via shortcuts in read only
2 participants
@philippotto @daniel-wer