Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion to dense resolution in case of anisotropic, partial resolutions #4344

Merged
merged 7 commits into from
Dec 2, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 27, 2019

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • The test case I added should be enough.

Issues:


@philippotto philippotto self-assigned this Nov 27, 2019
@philippotto philippotto changed the title Fx conversion to dense resolution in case of anisotropic, partial resolutions Fix conversion to dense resolution in case of anisotropic, partial resolutions Nov 27, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks for adding the test, it was very helpful in understanding the issue :) 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Daniel <[email protected]>
@bulldozer-boy bulldozer-boy bot merged commit bcc2bd2 into master Dec 2, 2019
@bulldozer-boy bulldozer-boy bot deleted the fix-partial-resolution-conversion branch December 2, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong conversion to dense resolution if resolutions are anisotropic and partial
2 participants