Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting in antd dataset table #4318

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Fix sorting in antd dataset table #4318

merged 2 commits into from
Nov 13, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 12, 2019

URL of deployed dev instance (used for testing):

Steps to test:

  • sort dataset table and also make use of the expand/collapse feature (the sticky action column should turn un-sticky if something is expanded)

Issues:


@philippotto philippotto self-assigned this Nov 12, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix 👍

@@ -287,7 +287,7 @@ class TracingActionsView extends React.PureComponent<Props, State> {
key="sandbox-tooltip"
>
<Button disabled type="primary" icon="code-sandbox">
Sandbox
<span className="hide-on-small-screen">Sandbox</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bulldozer-boy bulldozer-boy bot merged commit 6fe5902 into master Nov 13, 2019
@bulldozer-boy bulldozer-boy bot deleted the fix-sort branch November 13, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting in tables seems to be broken
2 participants