Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation readAccessQ #4314

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Fix annotation readAccessQ #4314

merged 4 commits into from
Nov 14, 2019

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Nov 8, 2019

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • try to access an annotation that is from someone within your org but from a different team
  • note that the requesting user should not be a part of the team to which the annotation belongs

Issues:



@youri-k youri-k requested a review from fm3 November 8, 2019 13:49
@youri-k youri-k self-assigned this Nov 8, 2019
@youri-k
Copy link
Contributor Author

youri-k commented Nov 8, 2019

I think this went unnoticed because most of the times the organization team is selected as the annotation team

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I read this is that this PR relaxes the condition that you can only see annotations of a team in which you are yourself to you can see all annotations of your organization.
This matches the descriptive text in the user modal, so I suppose this is what we want. I’m not sure though when this was (supposed to be) changed (or was this query wrong in the first place?) Do you remember?
Also, could you please add this fix to the changelog?

@youri-k youri-k merged commit d4970c3 into master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants