Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve publication list rendering #4248

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Improve publication list rendering #4248

merged 1 commit into from
Aug 22, 2019

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Aug 22, 2019 •
edited
Loading

URL of deployed dev instance (used for testing):

  • Makes each publication item in the gallery an own rendering layer (with translateZ(0))

Steps to test:

  • Apply the changes in the dev console on webknossos.org

Paint flashing

Before:
Aug-22-2019 13-49-23

After:
Aug-22-2019 13-49-39

  • Ready for review

@normanrz normanrz self-assigned this Aug 22, 2019
daniel-wer
daniel-wer approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you notice a performance improvement?

@bulldozer-boy bulldozer-boy bot merged commit f1b5c5c into master Aug 22, 2019
@bulldozer-boy bulldozer-boy bot deleted the normanrz-patch-1 branch August 22, 2019 12:47
@normanrz
Copy link
Member Author

Yes, I noticed less white (unrendered) areas when scrolling through the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@normanrz normanrz

Labels
automerge frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @daniel-wer