Advanced search for comments #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on hold for #4225 |
| onChange={evt => | ||
| this.setState({ searchQuery: evt.target.value, currentPosition: null }) | ||
| } | ||
| addonAfter={`${currentPosition + 1}/${numberOfAvailableOptions}`} | ||
| autoFocus | ||
| /> | ||
| <Tooltip title="Previous"> | ||
| <Tooltip title="Previous (shift+enter)"> |
There was a problem hiding this comment.
I added the shortcut in brackets so that it is easier to find for users. @daniel-wer do you think this is too much?
There was a problem hiding this comment.
I think it's very helpful as part of the tooltip :)
daniel-wer
approved these changes
Aug 21, 2019
| onChange={evt => | ||
| this.setState({ searchQuery: evt.target.value, currentPosition: null }) | ||
| } | ||
| addonAfter={`${currentPosition + 1}/${numberOfAvailableOptions}`} | ||
| autoFocus | ||
| /> | ||
| <Tooltip title="Previous"> | ||
| <Tooltip title="Previous (shift+enter)"> |
There was a problem hiding this comment.
I think it's very helpful as part of the tooltip :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the search in comments tab with the new advanced search. I also added the
enter+shiftshortcut to cycle backward through the results. Previously only theentershortcut to cycle forward existed. As far as I can remember theenter+shiftshortcut is common for all kind of search functionalities and therefore should be more or less discoverable.URL of deployed dev instance (used for testing):
Steps to test:
shift+crtl+f) or/and via the button. Both should work out fine.enter(select next) andshift+enter(select previous) shortcut.Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment