Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zip name when uploading hybrid/volume/collection #4222

Merged
merged 8 commits into from
Aug 12, 2019

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 7, 2019

URL of deployed dev instance (used for testing):

Steps to test:

  • upload zipped annotation, zip name should be used for the annotation
  • upload single nml (no zip), its name should still be used for the annotation

Issues:


@fm3 fm3 added the backend label Aug 7, 2019
@fm3 fm3 self-assigned this Aug 7, 2019
@fm3 fm3 requested a review from jstriebel August 7, 2019 12:19
@@ -58,7 +58,7 @@ class AnnotationIOController @Inject()(nmlWriter: NmlWriter,

private def nameForNmls(fileNames: Seq[String]) =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private def nameForNmls(fileNames: Seq[String]) =
private def nameForUpload(fileNames: Seq[String]) =

Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fm3 fm3 added the automerge label Aug 12, 2019
@bulldozer-boy bulldozer-boy bot merged commit d00f9ad into master Aug 12, 2019
@bulldozer-boy bulldozer-boy bot deleted the zip-upload-use-name branch August 12, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use name of ZIP file as name for hybrid tracing
3 participants