Skip to content

Activate user time tracking for non-admins #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 14, 2019
Merged

Activate user time tracking for non-admins #4220

merged 6 commits into from
Aug 14, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 7, 2019 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • I logged in as a normal user and verified that I can only see my own logs (I also send a curl request for another account id and didn't receive logs)
  • I logged in as an admin and verified that I can see everything as usual

Issues:

  • Updated changelog
  • Ready for review
  • wait for final "go" from the lab

@philippotto philippotto self-assigned this Aug 7, 2019
@philippotto philippotto requested a review from daniel-wer August 7, 2019 09:25
daniel-wer
daniel-wer approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philippotto philippotto merged commit db6403d into master Aug 14, 2019
@philippotto philippotto deleted the allow-users-to-see-time-tracking branch June 14, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to see their own time statistics
3 participants
@philippotto @daniel-wer @normanrz