Prefix local storage access with user email address #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
requested changes
Aug 7, 2019
frontend/javascripts/oxalis/view/layouting/layout_persistence.js
Outdated
Show resolved
Hide resolved
| }, | ||
|
|
||
| removeItem(key: string): void { | ||
| return localStorage.removeItem(key); |
There was a problem hiding this comment.
Shouldn't this also use prefixKey(key)?
There was a problem hiding this comment.
Whoops, well spotted! 👍
|
Thanks for your review and the commit suggestions 👍 Should be ready now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
main.js, the entire rendering of views is blocked by loading the active user. So, simply depending on the store synchronously should work pretty well. For the layouts, my testing showed that everything works as expected, except for logging in on a tracing page without reloading. One could expect that the layout is changed automatically (to the last layout used by the logged in user). However, the layout code itself is quite brittle which is why I didn't want to touch that. Also, the impact isn't really big. What happens now is that the layout stays the same, but after reloading the last active layout (by the user) is loaded again.URL of deployed dev instance (used for testing):
Steps to test:
Issues: