Turning off recording when leaving arbitrary modes #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBuessemeyer
changed the title
daniel-wer
approved these changes
Jul 30, 2019
| class ViewModesView extends PureComponent<Props, {}> { | ||
| blurElement = (event: SyntheticInputEvent<>) => { | ||
| event.target.blur(); | ||
| }; | ||
|
|
||
| handleChange = (mode: ViewMode) => { | ||
| // If we switch back from any arbitrary mode we stop recording. | ||
| // This prevents that when the user switches back to any flightmode, |
There was a problem hiding this comment.
Suggested change
| // This prevents that when the user switches back to any flightmode, | |
| // This prevents that when the user switches back to any arbitrary mode, |
| class ViewModesView extends PureComponent<Props, {}> { | ||
| blurElement = (event: SyntheticInputEvent<>) => { | ||
| event.target.blur(); | ||
| }; | ||
|
|
||
| handleChange = (mode: ViewMode) => { | ||
| // If we switch back from any arbitrary mode we stop recording. | ||
| // This prevents that when the user switches back to any flightmode, | ||
| // a new node is instantly created at the screens center. |
There was a problem hiding this comment.
Suggested change
| // a new node is instantly created at the screens center. | |
| // a new node is instantly created at the screen's center. |
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md). | |||
| ### Changed | |||
| - Volume project download zips are reorganized to contain a zipfile for each annotation (that in turn contains a data.zip and an nml file). [#4167](https://github.com/scalableminds/webknossos/pull/4167) | |||
| - Team managers and admins can now get tasks that they had previously cancelled. [#4088](https://github.com/scalableminds/webknossos/pull/4088) | |||
| - Automatically turning off recording for arbitrary modes when switching to orthogonal mode to prevent accidental creation of nodes when switching back to any arbitrary mode. [#4211](https://github.com/scalableminds/webknossos/pull/4211) | |||
There was a problem hiding this comment.
Arbitrary mode is probably hard to understand for our users, let's use the terms they know from the UI :)
Suggested change
| - Automatically turning off recording for arbitrary modes when switching to orthogonal mode to prevent accidental creation of nodes when switching back to any arbitrary mode. [#4211](https://github.com/scalableminds/webknossos/pull/4211) | |
| - Recording is now automatically turned off when switching from flight/oblique to orthogonal mode to prevent accidental node creation when switching back later. [#4211](https://github.com/scalableminds/webknossos/pull/4211) |
…noff-recording-in-orthogonal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically turns off recording when switching from arbitrary mode to orthogonal mode.
This solves the issue when having recording enabled and then switching to orthogonal, moving around and then switching back to any arbitrary view mode a new node is created instantly.
Now the user has to turn on the recording on changing back to any arbitrary mode.
URL of deployed dev instance (used for testing):
Steps to test:
If this procedure is done while flight mode is in watching mode (not recording), then no new nodes are created.
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment