Allow experience domains creation in task creation #4119
Conversation
MichaelBuessemeyer
changed the title
| @@ -410,7 +410,7 @@ class ExperienceModalView extends React.PureComponent<Props, State> { | |||
| ) : null} | |||
| <SelectExperienceDomain | |||
| disabled={false} | |||
| mode="tags" | |||
There was a problem hiding this comment.
The mode property is no longer needed here. It served the purpose to be able to select the entered text/experience domain although it is not included in the suggestions. As I implemented this behaviour manually, this is no longer required. Please note that the approach "changing mode to 'tags' in task_create_form_view" does change the behaviour of the select and thus this is not an option for the task creation view.
|
@daniel-wer Could I please get your review on this PR? |
| !options.includes(currentlyEnteredDomain) && | ||
| currentlyEnteredDomain.trim() !== "" | ||
| ) { | ||
| options.push(currentlyEnteredDomain); |
There was a problem hiding this comment.
I'm a bit hesitant about the modification of options here. Currently it's not a problem as state.domains is filtered in getUnusedDomains and returns a new array, but this could easily change in the future. This could then result in a hard to find state modification error.
Maybe change options to a let and then do options = [...options, currentlyEnteredDomain];
There was a problem hiding this comment.
Thanks for paying attention to this 👍
…webknossos into allow-exp-domain-creation
This PR makes it possible to add new experience domains while creating tasks.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment