Speed up mapping creation/activation #4103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up mapping creation/activation of large mappings substantially (~5-6x faster). Key optimizations are:
Example: Activating the
astrocyte-full
mapping went from taking 41.1s overall to taking 8.7s overall for me. The time to create the texture went from taking 23.3s to taking 3.8s.I added a screenshot test for mappings while I was at it :)
URL of deployed dev instance (used for testing):
Steps to test:
webknossos.apiReady().then(async api => api.data.setMapping("segmentation", { <visible_id>: 0}))