Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring scrolling input when dragging on a plane #4085

Merged
merged 7 commits into from
May 13, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented May 8, 2019

This PR disables scrolling while dragging a plane.

URL of deployed dev instance (used for testing):

Steps to test:

  • Open some tracing.
  • Scrolling should not work while dragging a plane.
  • Scrolling should work when not dragging.
  • Dragging so far that the mouse enters another plane and then scrolling still should disable scrolling.

Issues:


TODO

  • Handle the 4th behavior mentioned in steps to test.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🎉 The change works really well. I added a suggestion for the "drag into other plane and scroll there" problem. Didn't test it, though. If it works, I'll approve :)

frontend/javascripts/libs/input.js Outdated Show resolved Hide resolved
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully! See my one last minor comment, though :)

@philippotto philippotto merged commit 716fcfc into master May 13, 2019
@philippotto philippotto deleted the dont-scroll-while-dragging branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Apple Magic Mouse support
2 participants