-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to see their time statistics #4028
Conversation
TODO-frontend
|
@fm3 I just pushed a version which seems to be working. Would you be so kind and double check especially that we're not introducing data leaks. Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM + tested :)
@philippotto Could you please review the frontend changes :)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, the code itself looks good! However, the lab told us to do other improvements on the time statistics before releasing it to the hiwis (see #4076). So, this PR is blocked by that, too. I'd suggest to do the broader improvements in this PR, as well. Let's talk about at the sprint meeting tomorrow.
Frontend TODOs
|
When the timestamps of an ending of a task and the beginning of another take are very close, the second element might be wrapped into another row.
There were posts but none of the suggested fixed worked :/ @philippotto Could you please review the changes for the first time 🙂 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The code looks good 👍 Let's wait for the lab feedback now.
render() { | ||
const columns = [ | ||
{ id: "AnnotationId", type: "string" }, | ||
// This label columns is somehow needed to make the custom tooltip work. | ||
{ type: "string", id: "empty label" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... Out of curiosity, how did you find that workaround? Was it posted somewhere? If so, you could add the link so that we can follow-up with this later (maybe this will be fixed in another version of the plotting lib).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual hint was here https://developers.google.com/chart/interactive/docs/gallery/timeline#customizing-tooltips:
Hovering over a bar brings up a tooltip with the text defined in the third column. In this chart, we have to set the second column to dummy values (here, null) so that our tooltips can exist in the third column.
Imo This does not make any sense, but it finally worked after reading this 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you add the link as a comment to the code? :)
@MichaelBuessemeyer Could you please remove the "time tracking link" for ordinary users (so that they won't be able to see the view) and then get this PR ready to merge? The lab wants the UX improvements first and in the second round, we can make it available to all users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR enables the time statistics for non-admin users. If the user is not an admin, the view just displays the logged in user's time statistics.
Currently, the view can only be opened at
<base-url>/reports/timetracking
if you are not an admin.There needs to be a link added to this view e.g. in the navbar.
URL of deployed dev instance (used for testing):
Steps to test:
<base-url>/reports/timetracking
.Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment