Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mappings in volume/hybrid tracings #3949

Merged
merged 4 commits into from
Mar 28, 2019

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Mar 27, 2019

... that are based on an existing segmentation. For volume tracings with a completely new segmentation, it doesn't really make sense to apply mappings from the server.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a new volume tracing based on the existing segmentation! on a dataset that has mappings.
    • You should be able to use the mappings UI to list the available mappings and select specific mappings.
    • You should be able to programatically add a new mapping, e.g.: using webknossos.apiReady(3).then(async (api) => {api.data.setMapping(api.data.getVolumeTracingLayerName(), {7353: 1337})}) (replace first id with one you can see in the view)
  • Selecting mappings in a skeleton tracing or when viewing a dataset should still work

Issues:


Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect PR 👍 Works flawlessly, too 🎉

@daniel-wer daniel-wer merged commit be80374 into master Mar 28, 2019
@daniel-wer daniel-wer deleted the enable-mappings-in-volume-tracing branch March 28, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable segmentation mappings in tracing modes
2 participants