Removes fps meter #3916
Merged
Removes fps meter #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
reviewed
Mar 20, 2019
| @@ -77,6 +77,10 @@ class ArbitraryController extends React.PureComponent<Props> { | |||
| listenTo: Function; | |||
| stopListening: Function; | |||
|
|
|||
| static defaultProps = { | |||
| onRender: () => {}, | |||
There was a problem hiding this comment.
I think, onRender was only used by the fps meter. So, the prop can be removed completely from my point of view (same for plane_controller).
|
@philippotto @MichaelBuessemeyer In case you still want to measure FPS from time to time (as I think it can be quite helpful), the chrome FPS meter can be enabled in the dev console by opening the Command Palette (Ctrl + Shift + P) and entering FPS :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test:
Issues:
- [ ] Updated migration guide if applicable- [ ] Updated documentation if applicable- [ ] Adapted wk-connect if datastore API changes- [ ] Needs datastore update after deployment