Skip to content

Fix bi- and trilinear filtering along z axis #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2019
Merged

Fix bi- and trilinear filtering along z axis #3888

merged 2 commits into from
Mar 13, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Mar 12, 2019 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • toggle bilinear filtering and ensure that filtering is done in all three data panes in ortho mode
  • also check filtering in flight mode (cant be toggled via settings)

Issues:

@philippotto philippotto self-assigned this Mar 12, 2019
@philippotto philippotto requested a review from daniel-wer March 12, 2019 16:33
daniel-wer
daniel-wer approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet find :)

@philippotto philippotto merged commit 643ce3f into master Mar 13, 2019
@normanrz normanrz deleted the z-filtering branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interpolation along z dimension doesn’t work
2 participants
@philippotto @daniel-wer