Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable maximized gl components #3876

Merged
merged 20 commits into from
Mar 20, 2019
Merged

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Mar 8, 2019

This PR enables the maximize functionality of golden layout. The changes are kept to a minimum by only changing CSS properties. Except for the maximized item, the items must be hidden (this includes the header of a golden layout component). To perform this the content of the page is directly edited via the DOM interface.

known issues

  • The 3d viewport does not render correctly when maximized, as the other viewports are not rendered.
  • After resuming from the maximized version the 3d Viewport is broken.

URL of deployed dev instance (used for testing):

Steps to test:

  • open any kind of tracing view.
  • arrange the components of the view freely.
  • maximize one component by using the maximize icon in on the right side of the header of a component.
  • If a stack is maximized, changing tabs should work out and should not close the maximized view.
  • There should not be any borders or headers of "hidden" components visible.
  • leaving the maximized view should work out fine and the layout should be the same as before.
  • The maximized state should be saved, when reloading (assuming the layout was saved via auto save or manually)

Issues:


@MichaelBuessemeyer MichaelBuessemeyer changed the title [WIP] Enable maximized gl components Enable maximized gl components Mar 12, 2019
@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto This PR is ready for your review 👍

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 Feels really good!

The 3d viewport does not render correctly when maximized, as the other viewports are not rendered.

I think, this is alright. It's not a bug per se, in my opinion, but only a logical consequence from the design choices we made.

After resuming from the maximized version the 3d Viewport is broken.

This is probably strongly related to the other issues with the 3d viewport, right? Or is this the bug you created another issue for which already exists on master?

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Please don't forget to update the changelog before merging.

@philippotto philippotto merged commit c8c37e8 into master Mar 20, 2019
@philippotto
Copy link
Member

@MichaelBuessemeyer I took the liberty to merge this PR, since it's a cool feature and I wanted to land it :)

@daniel-wer daniel-wer deleted the enable-maximized-gl-components branch March 20, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable maximize option in golden layout
2 participants