-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable maximized gl components #3876
Conversation
…bknossos into sort-select-mappings-ui
…ble-maximized-gl-components
@philippotto This PR is ready for your review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍 Feels really good!
The 3d viewport does not render correctly when maximized, as the other viewports are not rendered.
I think, this is alright. It's not a bug per se, in my opinion, but only a logical consequence from the design choices we made.
After resuming from the maximized version the 3d Viewport is broken.
This is probably strongly related to the other issues with the 3d viewport, right? Or is this the bug you created another issue for which already exists on master?
frontend/javascripts/oxalis/view/layouting/golden_layout_adapter.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/layouting/golden_layout_adapter.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/layouting/golden_layout_adapter.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/layouting/golden_layout_adapter.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Please don't forget to update the changelog before merging.
@MichaelBuessemeyer I took the liberty to merge this PR, since it's a cool feature and I wanted to land it :) |
This PR enables the maximize functionality of golden layout. The changes are kept to a minimum by only changing CSS properties. Except for the maximized item, the items must be hidden (this includes the header of a golden layout component). To perform this the content of the page is directly edited via the DOM interface.
known issues
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment