Skip to content

Make inner node of active active node exactly as a non-active node #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2019
Merged

Make inner node of active active node exactly as a non-active node #3868

merged 5 commits into from
Mar 7, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Mar 6, 2019 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • activate nodes

@philippotto philippotto self-assigned this Mar 6, 2019
@philippotto philippotto requested a review from daniel-wer March 6, 2019 12:45
@philippotto
Copy link
Member Author

Ok, I made the active node round again so that it is recognizable in arbitrary view (since this won't show any halo).

@philippotto philippotto merged commit f2a27b4 into master Mar 7, 2019
jstriebel pushed a commit that referenced this pull request Mar 7, 2019
@philippotto @jstriebel
Make inner node of active active node exactly as a non-active node (#…
6253075 
…3868)

* make inner node of active active node exactly as a non-active node

* update changelog

* make node round in arbitrary view

* update changelog
@normanrz normanrz deleted the active-node-size branch August 12, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer