Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting mappings in UI #3864

Merged
merged 6 commits into from
Mar 11, 2019
Merged

Sorting mappings in UI #3864

merged 6 commits into from
Mar 11, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Mar 5, 2019

This PR sorts the mappings listed in the dropdown of the segmentation info tab.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open a tracing and open the segmentation tab
  • enable mappings by activating the check button
  • the listed mappings in the dropdown below the button should now be sorted.

Issues:

FYI:

  • I needed to create a copy of the mappings of the segmenatation layer because sort sorts inplace and the mappings array is set to rread only.

Copy link
Contributor Author

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippotto ok I change it, to use the slice function, as you proposed.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@MichaelBuessemeyer MichaelBuessemeyer merged commit ba9f854 into master Mar 11, 2019
@normanrz normanrz deleted the sort-select-mappings-ui branch August 12, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Mappings in Mappings UI
2 participants