Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aspect ratio of 3D viewport when layout changes #3817

Merged
merged 4 commits into from
Feb 25, 2019
Merged

Update aspect ratio of 3D viewport when layout changes #3817

merged 4 commits into from
Feb 25, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Feb 21, 2019 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • change layout and ensure that the 3d viewport keeps it's aspect ratio

Issues:

@philippotto philippotto self-assigned this Feb 21, 2019
daniel-wer
daniel-wer approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works very well :)

@philippotto philippotto merged commit ac6eb82 into master Feb 25, 2019
@philippotto philippotto deleted the fix-3d-view-aspect-ratio branch May 20, 2019 09:12
@philippotto philippotto restored the fix-3d-view-aspect-ratio branch May 20, 2019 09:12
@philippotto philippotto deleted the fix-3d-view-aspect-ratio branch May 20, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that aspect ratio in 3D viewport is updated correctly when changing layout
2 participants
@philippotto @daniel-wer