Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL hash change #3746

Merged
merged 5 commits into from
Feb 12, 2019
Merged

Fix URL hash change #3746

merged 5 commits into from
Feb 12, 2019

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Feb 11, 2019

As a result of this fix, hash changes in the URL will now be reflected in the tracing without a reload :) (There's a slight delay, where the hash changes back to the original value first and then to the correct value - this is because the hash is always rebuilt using the store as a ground truth)

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Check whether comment links still work
    • Create a comment with the string #1 and click on it, the node with id 1 should be activated
  • Change the URL hash
    • Change the position in the URL hash, the tracing position should change accordingly

Issues:


Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@daniel-wer daniel-wer merged commit f19b7f1 into master Feb 12, 2019
@daniel-wer daniel-wer deleted the hash-update branch February 12, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when changing the position in the URL hash
2 participants