Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tracing on public datasets of other organizations #3533

Merged
merged 4 commits into from
Dec 6, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Dec 5, 2018

Easy fix. However, this creates a new ambiguity: in NML files, the organization is not specified with the dataset name. So far, when uploading NMLs, we picked the dataset of the user. Now, we use the disambiguation route. A better solution would be to persist the organization to NML. Any comments on that thought?

Steps to test:

  • enable organization creation, disable autologin
  • set one dataset to public
  • create new organization via /onboarding
  • as the user of that organization, you should see the public dataset + be able to trace
  • download and re-upload NML of that tracing

Issues:


@fm3 fm3 added the backend label Dec 5, 2018
@fm3 fm3 self-assigned this Dec 5, 2018
@fm3 fm3 requested a review from youri-k December 5, 2018 17:03
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the edge case where there are two datasets with the same name and the public dataset is newer and someone from the other org tries to upload a tracing to this dataset, but I don't see a way to work around this.

@fm3 fm3 merged commit 2998ce3 into master Dec 6, 2018
@fm3 fm3 deleted the trace-public-datasets-of-other-orga branch December 6, 2018 14:52
@fm3
Copy link
Member Author

fm3 commented Dec 6, 2018

created follow-up issue #3536 to track that

@normanrz
Copy link
Member

normanrz commented Dec 7, 2018

@fm3 could we cherry-pick this to demo instance?

@fm3
Copy link
Member Author

fm3 commented Dec 7, 2018

@normanrz sure. should we just install the resulting branch on demo or create a 18.11.1 release? Or just roll demo to the corresponding master build from yesterday?

@normanrz
Copy link
Member

normanrz commented Dec 8, 2018

Let's roll to master on monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create annotations for public datasets of other orgs doesn't work
3 participants