Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that resolutions array is dense #3406

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Ensure that resolutions array is dense #3406

merged 3 commits into from
Nov 5, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Oct 25, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I opened a dataset with sparse resolutions (e.g., [[1, 1, 1], [16, 16, 16]]). This is the case for 2012-09-28_ex145_07x2_new2. I ensured that wk does not break when zooming out and that data is visible for mag 1 and 5 at the right places. I think there is no need to have somebody else check this.
  • I also ran the screenshot tests which passed

Issues:

@philippotto philippotto self-assigned this Oct 25, 2018
daniel-wer
daniel-wer approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍, in my understanding this also works if the first resolution was left out, for example, so for datasets with resolutions [2, 2, 1], [4, 4, 2]]. In that case it would add the first resolution [1, 1, 1], right? :)

@philippotto
Copy link
Member Author

Nice +1, in my understanding this also works if the first resolution was left out, for example, so for datasets with resolutions [2, 2, 1], [4, 4, 2]]. In that case it would add the first resolution [1, 1, 1], right? :)

Yes, that case is covered, too :)

@philippotto philippotto merged commit 3f84d22 into master Nov 5, 2018
jfrohnhofen added a commit that referenced this pull request Nov 22, 2018
@jfrohnhofen
Merge branch 'master' into isosurface
26bb166 
* master:
  Fix rgb support (#3455)
  Fix docker uid/gid + binaryData permissions. Persist postgres db (#3428)
  Script to merge volume tracing into on-disk segmentation (#3431)
  Hotfix for editing TaskTypes (#3451)
  fix keyboardjs module (#3450)
  Fix guessed dataset boundingbox for non-zero-aligned datasets (#3437)
  voxeliterator now checks if the passed map has elements (#3405)
  integrate .importjs (#3436)
  Re-write logic for selecting zoom level and support non-uniform buckets per dimension (#3398)
  fixing selecting bug and improving style of layout dropdown (#3443)
  refresh screenshots (#3445)
  Reduce the free space between viewports in tracing (#3333)
  Scala linter and formatter (#3357)
  ignore reported datasets of non-existent organization (#3438)
  Only provide shortcut for tree search and not for comment search (#3407)
  Update Datastore+Tracingstore Standalone Deployment Templates (#3424)
  In yarn refresh-schema, also invalidate Tables.scala (#3430)
  Remove BaseDirService that watched binaryData symlinks (#3416)
  Ensure that resolutions array is dense (#3406)
  Fix bucket-collection related rendering bug (#3409)
@normanrz normanrz deleted the handle-sparse-resolutions branch February 20, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly deal with sparse resolutions
2 participants
@philippotto @daniel-wer