-
Notifications
You must be signed in to change notification settings - Fork 27
Store Meshes in Postgres #3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Meshes in Postgres #3367
Conversation
…ntroller singleton; finalize mesh support
@fm3 I added the front-end part and think this is ready to review. I made some small changes to the back-end which you might want to double check. Do you want to pull the master in and merge the back-end conflict? If you commit the frontend conflicts, I can resolve them then. |
@philippotto that’s great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean implementation 👍 I like that you focused on UX and made this an easily usable feature :)
The feature itself works really well :) There are still some things I noticed during manual testing:
|
I just tested again, arbitrary/flight mode works as expected, was probably related to the missing layout config version bump. :) |
* origin/master: Optimize performance for the list request /api/datasets (#3441) add annotation dataset foreign key (#3482) thumbnails: correctly use zoom value if specified (#3487) Store Meshes in Postgres (#3367) fix alpha return (#3483) Added script to apply all new evolutions (#3427) Simple fix to speed up dataset gallery (#3480) better errors for screenshot tests, fix imports, refresh screenshots (#3479) (Backend only) Add project priority to progress report json (#3476) Handle missing write access on datastore (#3411) Re-introduce "Flightmode improvements"" (#3473) Circleci-notify: linkify PR number (#3469) Revert "Flightmode improvements" (#3472) also flow-ignore binaryData when using symlinks (#3471) Flightmode improvements (#3392) Circleci custom notification (#3465) enable /api/switch cross-organization (#3464)
URL of deployed dev instance (used for testing):
@philippotto on this branch I added the new routes
the data is separate from the metadata.
metadata post and put (topmost) expect a json like
and return a json with meshInfo.
the annotation info request contains a new field
"meshes"
, listing the associated meshes. (the mesh metadata GET will probably not be used by the frontend)the data requests expect/deliver raw binary data. They will fail if the metadata is not created first.
@philippotto is this how you imagined it? Please ask questions or suggest changes :)
Do you want to implement the front-end part on this branch? (Or assign someone else, of course)
Steps to test:
Issues:
[ ] Needs datastore update after deployment