Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Datastore to watch multiple directories #3330

Merged
merged 8 commits into from
Oct 11, 2018
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 8, 2018

Steps to test:

  • create second dataset directory next to binaryData, insert it in application.conf braingames.binary.additionalFolders
  • datasets there should be listed, data loading should work
  • for the original directory also.

@normanrz do you think we should do some caching for the lookup determining which directory exists? I’m not sure how cache invalidation would work for this. But right now it feels like we’re introducing many additional disk accesses.

Issues:


@fm3 fm3 self-assigned this Oct 8, 2018
@normanrz
Copy link
Member

normanrz commented Oct 8, 2018

Maybe we could implement it like this: We keep one main folder, and have additional folders that are watched. When new folders in the additional folder are detected, a symlink is created to the main folder? That would also prevent duplicate dataset names.

@fm3
Copy link
Member Author

fm3 commented Oct 9, 2018

Good idea, I changed it according to your suggestion. Do you think we should also scan for and delete dangling symlinks?

@fm3 fm3 requested review from normanrz and youri-k October 9, 2018 12:16
@normanrz
Copy link
Member

normanrz commented Oct 9, 2018

Yes, I think we should also remove dangling links.

Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit 1141949 into master Oct 11, 2018
@fm3 fm3 deleted the datastore-multi-dir branch October 11, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants