-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Datastore to watch multiple directories #3330
Conversation
Maybe we could implement it like this: We keep one main folder, and have additional folders that are watched. When new folders in the additional folder are detected, a symlink is created to the main folder? That would also prevent duplicate dataset names. |
Good idea, I changed it according to your suggestion. Do you think we should also scan for and delete dangling symlinks? |
Yes, I think we should also remove dangling links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Steps to test:
braingames.binary.additionalFolders
@normanrz do you think we should do some caching for the lookup determining which directory exists? I’m not sure how cache invalidation would work for this. But right now it feels like we’re introducing many additional disk accesses.
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable