Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not line wrap comments #3272

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Do not line wrap comments #3272

merged 3 commits into from
Sep 24, 2018

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Sep 24, 2018 •
edited
Loading

I also disabled the bullet points in the comment tab, that were introduced by mistake some weeks ago.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Create a tracing with a very long tree name and a very long comment
  • Open the comment tab, the lines should not be wrapped, and you should be able to scroll in x-direction.

Issues:

@daniel-wer daniel-wer self-assigned this Sep 24, 2018
philippotto
philippotto approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 :)

@daniel-wer daniel-wer merged commit af1e3f5 into master Sep 24, 2018
@daniel-wer daniel-wer deleted the wide-comments branch September 24, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@daniel-wer daniel-wer

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments overflow for small panes
2 participants
@daniel-wer @philippotto