Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow accessing missing-buckets-header in CORS requests #3270

Merged
merged 7 commits into from
Sep 24, 2018
Merged

Allow accessing missing-buckets-header in CORS requests #3270

merged 7 commits into from
Sep 24, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 24, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • local set up is probably overkill. the fix shouldn't make things worse

Issues:

  • Updated changelog
  • Needs datastore update after deployment
  • Ready for review

@philippotto philippotto self-assigned this Sep 24, 2018
daniel-wer
daniel-wer approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed :)

@philippotto philippotto merged commit 5496c34 into master Sep 24, 2018
philippotto added a commit that referenced this pull request Sep 27, 2018
@philippotto
Allow accessing missing-buckets-header in CORS requests (#3270)
b499fae 
* allow accessing missing-buckets-header in cors requests (fixes #3269)

* update changelog

* fix syntax error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

@fm3 fm3 Awaiting requested review from fm3

Assignees

@philippotto philippotto

Labels
backend datastore-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MISSING-BUCKETS cannot be accessed due to CORS
2 participants
@philippotto @daniel-wer