Allow adding STL files to 3D scene #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Awesome! I'd say it works:
It would probably be nice to have the option to hide/remove these imported stl objects, right? Depending on whether stl files contain scaling information, we would also possibly need to scale them manually. Imo, all of this can also be done as part of a followup PR and once we got a segmentation STL file out of Amira.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic mesh rendering support for STL files. You can upload an STL which will be rendered within WK. The file won't be stored within the tracing nor are interactions with the mesh supported. We should discuss potential next steps.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: