Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AND search instead of OR everyhwere (fixes #3197) #3228

Merged
merged 4 commits into from
Sep 18, 2018
Merged

Use AND search instead of OR everyhwere (fixes #3197) #3228

merged 4 commits into from
Sep 18, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 14, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • use the search functionality in some views

Issues:

@philippotto philippotto self-assigned this Sep 14, 2018
daniel-wer
daniel-wer approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We could add a comment to the filterWithSearchQueryOR function, to remember to remove it in a couple of weeks (if it has not been needed again by then).

@philippotto philippotto merged commit 8a173eb into master Sep 18, 2018
@philippotto philippotto deleted the use-and-search-everywhere branch September 18, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify AND/OR search behavior functionality
2 participants
@philippotto @daniel-wer