Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nml parsing error messages for missing strings #3227

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Improve nml parsing error messages for missing strings #3227

merged 3 commits into from
Sep 17, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 14, 2018 •
edited
Loading

We had a faulty NML for a better error message would have been helpful.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • upload an NML where the name attribute is missing for a tree
  • there should be an error message pointing that out

@philippotto philippotto self-assigned this Sep 14, 2018
daniel-wer
daniel-wer approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@philippotto philippotto merged commit 7ecf652 into master Sep 17, 2018
@philippotto philippotto deleted the improve-nml-parsing-error-messages branch September 18, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer