Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in updateActionLog, annotate batches with version number #3203

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 12, 2018

[
  {
    "version": 7,
    "value" : [
      {<anUpdateAction>},
      {<anUpdateAction>}
    ]
  },
  {
    "version": 6,
    "value" : [
      {<anUpdateAction>},
      {<anUpdateAction>},
      {<anUpdateAction>}
    ]
  }
]

down to version 1
(version 0 of the tracing is the originally created one)

Steps to test:


  • Ready for review

@fm3 fm3 self-assigned this Sep 12, 2018
@fm3
Copy link
Member Author

fm3 commented Sep 12, 2018

@daniel-wer Is this how you need it?
Does it break the tracing statistics script?
Feel free to merge into your branch

@daniel-wer
Copy link
Member

Thanks @fm3!
Looks very good - the tracing statistics script no longer uses the updateActionLog endpoint but the annotation statistics instead, so no problem there :)

Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-wer daniel-wer merged commit b5179a9 into restore-old-versions Sep 12, 2018
@daniel-wer daniel-wer deleted the restore-old-versions-versionedlog branch September 12, 2018 11:22
@daniel-wer
Copy link
Member

This PR requires datastore changes right? Just want to make sure. If so I'll check that box in the version restore PR :)

@fm3
Copy link
Member Author

fm3 commented Sep 12, 2018

Yes, it does :)

daniel-wer added a commit that referenced this pull request Sep 17, 2018
* first working version of tracing version restore

* added types and categorized some update action batches to show better description and icon

* improve batch description, save before opening version restore view

* rework flow types for ServerUpdateActions

* fix missing null checks

* only scroll version list in version history view

* remove obsolete import

* PR feedback #1, show info alert instead of tracing actions

* in updateActionLog, annotate batches with version number (#3203)

* PR feedback #2, scroll into view, descriptions for other update actions

* adapt changelog and docs

* [docs] point to 'restore older version' from redo/undo, fix typo

* make version restore view's position fixed, style fixes, allow showVersionRestore url parameter that opens the version restore view without fetching the newest tracing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants