Finished Tasks sorting and UI rework #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Looking good :)
I would've liked to accomplish this without duplicating all the Card and Column code, but I also can't think of a nice way to do this without many `{this.state.showFinishedTasks ? ... : ...} conditionals, so I'd say it's fine.
While you're at it, can you change line 431, so that it displays "Finished Tasks" in the headline once the finished tasks are displayed. I wanted to do this for a long time :)
| ); | ||
| </Col> | ||
| <Col span={7}> | ||
| <b>Task Finished:</b> <FormattedDate timestamp={task.annotation.modified} /> |
There was a problem hiding this comment.
I'd say you can drop the word task here.
philippotto
added a commit
that referenced
this pull request
Sep 13, 2018
This reverts commit 2e08469.
philippotto
added a commit
that referenced
this pull request
Sep 13, 2018
* Revert "auto remove autogen flow-check files on git checkout (#3208)" This reverts commit 3e8c6b9. * Revert "Show success toast after resetting annotation in tasks view (#3207)" This reverts commit 42c1890. * Revert "Finished Tasks sorting and UI rework (#3202)" This reverts commit 2e08469. * Revert "Add URLs for dashboard tabs (#3183)" This reverts commit 0e29527.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the details displayed when showing finished tasks in the
dashboard/tasks-Tab. It also adds sorting by finished date / last modification.URL of deployed dev instance (used for testing):
Steps to test:
finished tasksis selectedId, project name, finish date and the check that indicates that this task is finishedshould be displayed in the list whenfinished tasksis selectedIssues: