Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NmlWriter TaskId meta tag #3166

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Fix NmlWriter TaskId meta tag #3166

merged 2 commits into from
Sep 6, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 6, 2018 •
edited
Loading

Steps to test:

  • create a task, trace some, download as nml
  • in resulting nml, there should be a meta name="taskId" content="…" tag

Issues:

@fm3 fm3 requested a review from philippotto September 6, 2018 13:02
@fm3 fm3 merged commit 98ab2ee into master Sep 6, 2018
@fm3 fm3 deleted the fix-nmlwriter-taskid branch September 6, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task download does not work
2 participants
@fm3 @philippotto