Showing welcome header when there are no organisations #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where there a no existing organisations
philippotto
reviewed
Sep 3, 2018
| const datasets = await getDatasets(); | ||
| this.setState({ datasets }); | ||
| const [datasets, organizations] = await Promise.all([getDatasets(), getOrganizations()]); | ||
| this.setState({ datasets, hasOrganisations: organizations.length > 0 }); |
There was a problem hiding this comment.
I'd suggest to also use the american english spelling for organization here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the welcome header at
/when no user is logged in and there are no existing organizations. It also disables the auto redirect toonboardingwhen entering there are no organizations.URL of deployed dev instance (used for testing):
Steps to test:
insertInitialData = truetofalse=> the path
/should show the welcome header even whenallowOrganizationCreationis set to false.And there should be no redirect to
onboarding.Issues: