Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom viewports #3070

Merged
merged 33 commits into from
Sep 17, 2018
Merged

Custom viewports #3070

merged 33 commits into from
Sep 17, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 17, 2018 •
edited
Loading

After the final go (+ my vactation), I'd like to merge this. k/l scale property has to be moved into the store again, but otherwise it should be good to go (except for merge conflicts probably).

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • abc

Issues:

@philippotto
Revert "Revert "Allow user-customizable viewport arrangements (#2570)""
34b7be9 
This reverts commit 5ad7dc6.
@philippotto
Revert "Revert "fix node selection; 3d viewport rotation/zooming; fix…
e874ef8 
… shortcuts (#2673)""

This reverts commit c95a064.
@philippotto
make gl style static to avoid re-mountings
d9b9502
@philippotto
workaround weird uglifyjs bug which remounts instead of rerenders som…
2872afd 
…e react components
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into cus…
616c225 
…tom-viewports
@philippotto
re-add snapshots
9e47341
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into cus…
010e5b7 
…tom-viewports
@philippotto
fix bug which caused hidden arbitrary view to be still rendered
86ededf
@philippotto
pretty code
4ff0621
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into cus…
079393f 
…tom-viewports
@philippotto
tmp: work on different default-layout(s)
895c673
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into cus…
3814c87 
…tom-viewports
@philippotto
Revert "tmp: work on different default-layout(s)"
edcc5ee 
This reverts commit 895c673.
@philippotto
tmp: re-add k/l for custom viewports
53606d8
@philippotto
pretty code
133352e
@philippotto
fix wrong method call
1c80101
@philippotto
update snapshots
b0716c8
@philippotto
update snapshots
5634a0b
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into cus…
855258d 
…tom-viewports
@philippotto philippotto self-assigned this Aug 17, 2018
@philippotto philippotto changed the title [Blocked] Custom viewports Custom viewports Sep 17, 2018
@philippotto philippotto merged commit 9eb6424 into master Sep 17, 2018
@philippotto philippotto deleted the custom-viewports branch September 18, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom viewport arrangement
2 participants
@philippotto @daniel-wer