Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow team managers to activate users #3050

Merged
merged 6 commits into from
Aug 14, 2018
Merged

allow team managers to activate users #3050

merged 6 commits into from
Aug 14, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 14, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • create user, activate as scmboy, give him team manager rights
  • register third user, log in as the team manager, try to activate the third user
  • should work

Issues:

  • Updated changelog
  • [ ] Updated migration guide if applicable
  • [ ] Needs datastore update after deployment
  • Ready for review

@fm3 fm3 self-assigned this Aug 14, 2018
@fm3 fm3 changed the title [WIP] allow team managers to activate/dactivate users allow team managers to activate users Aug 14, 2018
@fm3 fm3 requested a review from rschwanhold August 14, 2018 09:06
rschwanhold
rschwanhold approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@rschwanhold rschwanhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit ba35908 into master Aug 14, 2018
@fm3 fm3 deleted the teammanager-can-activate branch August 14, 2018 11:57
@daniel-wer daniel-wer mentioned this pull request Aug 20, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwanhold rschwanhold rschwanhold approved these changes

Assignees

@fm3 fm3

Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Team manager cannot activate new users
2 participants
@fm3 @rschwanhold