Scroll faster through tree comments #3041
Conversation
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md). | |||
|
|
|||
| - Added two new properties to mapping json files. The `colors: [<hsvHueValue1>, <hsvHueValue2>, ...]` property can be used to specify up to 256 custom colors for the first 256 equivalence classes of the mapping. The `hideUnmappedIds: <true|false>` property indicates whether segments that were not mapped should be rendered transparently or not. [#2965](https://github.com/scalableminds/webknossos/pull/2965) | |||
| - Added a button for refreshing the dataset in the backend cache. [#2975](https://github.com/scalableminds/webknossos/pull/2975) | |||
| - Comments of tracing trees are now scrollable by holding n and p pressed. [#3041](https://github.com/scalableminds/webknossos/pull/3041) | |||
There was a problem hiding this comment.
Scrollable does not describe this perfectly, I'd argue. I would use "cycle" instead:
Comments of tracing trees can now be cycled through by keeping n and p pressed.
| @@ -85,6 +87,7 @@ type CommentTabStateType = { | |||
|
|
|||
| class CommentTabView extends React.PureComponent<Props, CommentTabStateType> { | |||
| listRef: ?List; | |||
| storePropertyUnsubscribers: Array<Function>; | |||
There was a problem hiding this comment.
Function is a very generic flow type and should be avoided when possible, since it lacks parameter and return types. Just write () => void instead.
| @@ -105,6 +108,11 @@ class CommentTabView extends React.PureComponent<Props, CommentTabStateType> { | |||
| return { data }; | |||
| } | |||
|
|
|||
| constructor(...args: any) { | |||
There was a problem hiding this comment.
You don't need the constructor for this static assignment, instead you can do this right in line 90, as follows:
storePropertyUnsubscribers: Array<Function> = [];
|
@MichaelBuessemeyer I'd say in the future it is enough to assign one reviewer, otherwise you may end up with duplicate reviews :) |
|
@daniel-wer looks like a missclick to me 🙈 |
URL of deployed dev instance (used for testing):
Steps to test:
Issues: