Expose setActiveTree and setTreeColorIndex in API #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Aug 1, 2018
| * @example | ||
| * api.tracing.setTreeColorIndex(3, 10); | ||
| */ | ||
| setTreeColorIndex(treeId?: number, colorIndex: number) { |
There was a problem hiding this comment.
Does it make sense to have the first parameter as optional? Calling the function with only one parameter will produce an incorrect result.
There was a problem hiding this comment.
Yeah, that's right. I can add it to treeId: ?number to avoid confusion (even with treeId? one would have to call setTreeColorIndex(undefined, 3) to satisfy the interface).
There was a problem hiding this comment.
You could also switch the order of parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: