-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show inactive users warning #2994
Conversation
…ceholder-for-empty-views
…w-inactive-users-warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks really good.
Maybe we should add a small information icon next to the alert title, which says something like this on hover: "The displayed users are inactive and were created in the past 14 days.". This might avoid confusion if somebody willingly disables a user and cannot dismiss the list. In that case, the admin will understand that the alert will go away after some time.
I like the idea with small info icon, I'll add that :) |
I think we should defer this until we get feedback on that. I think it doesn't happen often, that a user is deactivated shortly after it was created. |
This PR adds an Antd Alert when there are new inactive users (<14 days). They can be activated directly from this Banner. The original issue #2928 also shows a delete button, but afaik we don't implement this functionality. Should this be added in your opinion? Otherwise there would be no way to get rid of unwanted users, as activating them would be the only option.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: