Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color unloaded data gray, even for last zoomstep #2963

Merged
merged 4 commits into from
Jul 25, 2018
Merged

Color unloaded data gray, even for last zoomstep #2963

merged 4 commits into from
Jul 25, 2018

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jul 25, 2018 •
edited
Loading

Unloaded data was not shown in gray for the very last zoomstep of a dataset.

URL of deployed dev instance (used for testing):

Steps to test:

  • Open the dataset 2012-09-28_ex145_07x2_corrected (which has only one zoomstep) and zoom out until at least 1.3.
  • Move around - unloaded data should be shown in gray, not black!

Issues:

@daniel-wer daniel-wer self-assigned this Jul 25, 2018
philippotto
philippotto approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Great job finding this!

@daniel-wer daniel-wer merged commit cedd05c into master Jul 25, 2018
@daniel-wer daniel-wer deleted the fix-unloaded-data-color branch July 25, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@daniel-wer daniel-wer

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unloaded data is rendered black instead of grey
2 participants
@daniel-wer @philippotto