Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position linking #2960

Merged
merged 5 commits into from
Jul 25, 2018
Merged

Fix position linking #2960

merged 5 commits into from
Jul 25, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jul 25, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • create an explorational
  • create some nodes and move the active position so that the active node is not centered
  • save and reload --> the previous position should be persisted
  • also: make sure that switching nodes animates the position as usual

@philippotto philippotto self-assigned this Jul 25, 2018
daniel-wer
daniel-wer approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find :)

@normanrz normanrz merged commit 132ea51 into master Jul 25, 2018
@normanrz normanrz deleted the fix-position-linking branch July 25, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

@normanrz normanrz Awaiting requested review from normanrz

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippotto @daniel-wer @normanrz