Drag'n'drop import of multiple NML files #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Jul 23, 2018
| <span className="ant-list-item-meta-description">({prettyBytes(file.size)})</span> | ||
| </span> | ||
| } | ||
| description={`Last modification date: ${moment(file.lastModifiedDate).format( |
There was a problem hiding this comment.
After #2916 was merged, we should use the FormattedDate component here as well :)
| // an error | ||
| importActions.forEach(action => Store.dispatch(action)); | ||
| } catch (e) { | ||
| Toast.error(e.message); |
There was a problem hiding this comment.
Do you think it's possible to show which specific NML file caused the error? Right now, it's hard to find out which file to look at if the NML import fails with an error message.
| <Modal | ||
| title={`Import ${this.state.files.length} NML file(s)`} | ||
| visible={this.state.files.length > 0} | ||
| onOk={this.importNmls} |
There was a problem hiding this comment.
With the dedicated submit button we should not need this, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated migration guide if applicable