-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to show random tasks #2860
Conversation
@rschwanhold : Please add the change notes to the changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me (but I’m a bit scared of the performance on a 3M-entry-table – but I assume this is not used with a super high frequency anyway). Backend code looks okay to me.
@philippotto could you have a look at the js changes? Also, do you think it is confusing that the loading symbol still appears in the original Search button rather than the new Show random subset button? Here, too, I think it’s acceptable but I’d like to hear your opinion.
We can test this directly after deployment. As long as the server doesn't freeze, everything should be fine. The functionality is probably not used very often.
Yes, I tweaked the code a bit and combined the two search buttons (which also solves the "wrong" place for the loading indicator). Should be good to go now. |
@fm3 the performance optimized way would be to use the "tablesample" method from postgres. This works really well for big tables, but this does only work with tables or materialized views. |
@rschwanhold ok, then let’s do it with |
Mailable description of changes:
Steps to test:
Issues: