Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in task creation, make initial node a branchpoint #2799

Merged
merged 4 commits into from
Jun 28, 2018
Merged

in task creation, make initial node a branchpoint #2799

merged 4 commits into from
Jun 28, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 25, 2018

Mailable description of changes:

  • Initial Node of new tasks (if not created via NML) is now a branchpoint

URL of deployed dev instance (used for testing):

Steps to test:

  • create task, request it
  • initial node should be branchpoint (set other node, pressing j should make cursor jump back)

Issues:

  • Ready for review

@fm3 fm3 self-assigned this Jun 25, 2018
@fm3 fm3 requested review from daniel-wer and jstriebel June 25, 2018 14:13
daniel-wer
daniel-wer approved these changes Jun 26, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works very well :)

jstriebel
jstriebel approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit db07a67 into master Jun 28, 2018
@fm3 fm3 deleted the task-initial-branchpoint branch June 28, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@fm3 fm3

Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial Node in Tasks should be branchpoint
3 participants
@fm3 @daniel-wer @jstriebel